Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Added a couple of new convenience methods to core, cleaned up some docs and formatting. #10

Merged
merged 3 commits into from
May 7, 2021

Conversation

daveshanley
Copy link
Collaborator

core fabric methods for errors added to allow payload and headers to be submitted. Also cleaned up some of the godoc in the service package. No breaking functionality. Also turned on go fmt, seems to have updated most of the service_registry

Signed-off-by: Dave Shanley dshanley@vmware.com

@vmwclabot
Copy link

@daveshanley, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

core fabric methods for errors added to allow payload and headers to be submitted. Also cleaned up some of the godoc in the service package.

Signed-off-by: Dave Shanley <dshanley@vmware.com>
Cleaner documentation and demo code is required to make these useful. demo needs to ne converted to connecting to local broker instead of cloud.

Signed-off-by: Dave Shanley <dshanley@vmware.com>
More examples and samples are required, however the galactic channels sample code has been updated to work against the local broker and not a non-public endpoint.

Signed-off-by: Dave Shanley <dshanley@vmware.com>
@codecov-commenter
Copy link

Codecov Report

Merging #10 (9b1a618) into main (b61c1d5) will decrease coverage by 0.05%.
The diff coverage is 94.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   97.32%   97.27%   -0.06%     
==========================================
  Files          26       26              
  Lines        1721     1725       +4     
==========================================
+ Hits         1675     1678       +3     
- Misses         46       47       +1     
Flag Coverage Δ
unittests 97.27% <94.64%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
service/service_registry.go 94.23% <94.23%> (ø)
service/fabric_core.go 100.00% <100.00%> (ø)
bus/transaction.go 91.30% <0.00%> (-1.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b61c1d5...9b1a618. Read the comment docs.

@daveshanley
Copy link
Collaborator Author

@jooskim can we reduce the reviewer requirement down to one?

@daveshanley daveshanley merged commit 37278cf into main May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants